Draw the pen's wet stroke over containers, not under them - #74
Merged
Conversation
Pen ink moved out of the InkCanvas and into BoardSurface.OnRender, where draw order matters, and the pending stroke was drawn before the document objects. Images, text and LiveViews therefore painted over the wet ink, which reappeared only on lift, when the stroke commits with the topmost z-index. It is now drawn after the objects and before the hover and selection chrome, which is where it will sit once committed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #73.
Pen ink moved out of the
InkCanvasand intoBoardSurface.OnRender, where draworder matters — and the pending stroke was drawn before the loop over document
objects. Images, text and LiveViews therefore painted straight over the wet ink,
so a stroke crossing a container was invisible exactly where it overlapped and
appeared all at once on lift, when it commits with the topmost z-index.
It is now drawn after the objects and before the hover and selection chrome,
which is where it will sit once committed.
Version 1.1.2. Release build clean with
TreatWarningsAsErrors, smoke tests pass.🤖 Generated with Claude Code